Enhance mdexport to annotate rand() and randn() using sympy#63
Open
Utkarsha2811 wants to merge 3 commits intobrian-team:masterfrom
Open
Enhance mdexport to annotate rand() and randn() using sympy#63Utkarsha2811 wants to merge 3 commits intobrian-team:masterfrom
Utkarsha2811 wants to merge 3 commits intobrian-team:masterfrom
Conversation
Member
|
Hi @Utkarsha2811. Thanks for the PR! I won't be able to review it right away, so please be a bit patient. |
Contributor
Author
Thanks, Meanwhile I'll recheck and update PR description. |
Member
|
Hi @Utkarsha2811, sorry for the delay in getting back to this PR. Since you opened it, the |
Contributor
Author
|
Hey @mstimberg, I've merged master so the test suite will run. I also took the opportunity to do some minor refactoring and added tests while I was at it. Let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The Markdown exporter currently displays raw strings for initializations using rand() and randn() without providing mathematical context.
Solution: I used SymPy to analyze these expressions. The exporter now calculates and displays exact lower/upper bounds for rand() and the mean/variance for randn() in the exported Markdown descriptions.